Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deterministic build and SourceLink + VS 2019 on CI #19

Closed
wants to merge 3 commits into from
Closed

Enable deterministic build and SourceLink + VS 2019 on CI #19

wants to merge 3 commits into from

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Mar 23, 2021 •
edited
Loading

Enabled sourcelink and deterministic build for all projects

Todo:

  • test publish before merge!

See also https://github.com/clairernovotny/DeterministicBuilds

related NLog/NLog.Web#639

@304NotModified
Copy link
Member Author

VS2019 breaks on licenseurl and icon

NU5125: The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead. [C:\projects\nlog-azureappcenter\src\NLog.Targets.AppCenter\NLog.Targets.AppCenter.csproj]
C:\Program Files\dotnet\sdk\5.0.201\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [C:\projects\nlog-azureappcenter\src\NLog.Targets.AppCenter\NLog.Targets.AppCenter.csproj]

@snakefoot
Copy link
Collaborator

Everything fixed with #23

@snakefoot snakefoot closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@304NotModified @snakefoot